Bug 215207

Summary: Remove UIScriptController.removeAllDynamicDictionaries()
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Take 2 none

Description Wenson Hsieh 2020-08-05 19:11:38 PDT 
SSIA
Comment 1 Wenson Hsieh 2020-08-05 19:16:42 PDT 
Created attachment 406068 [details]
Patch
Comment 2 Wenson Hsieh 2020-08-06 07:38:46 PDT 
Comment on attachment 406068 [details]
Patch

Thanks for the review!
Comment 3 EWS 2020-08-06 07:46:40 PDT 
Committed r265325: <https://trac.webkit.org/changeset/265325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406068 [details].
Comment 4 Wenson Hsieh 2020-08-06 13:19:42 PDT 
It looks like a handful of layout tests in fast/forms and editing/pasteboard are timing out after this change, due to hangs underneath UIKeyboardImpl :(
Comment 5 Wenson Hsieh 2020-08-06 13:21:12 PDT 
Reverted r265325 for reason:

Caused several tests in fast/forms and editing/pasteboard to time out

Committed r265345: <https://trac.webkit.org/changeset/265345>
Comment 6 Wenson Hsieh 2020-08-06 17:12:37 PDT 
Created attachment 406136 [details]
Take 2
Comment 7 Wenson Hsieh 2020-08-07 08:52:03 PDT 
Comment on attachment 406136 [details]
Take 2

Thank you for the review!
Comment 8 EWS 2020-08-07 09:14:33 PDT 
Committed r265376: <https://trac.webkit.org/changeset/265376>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406136 [details].