Bug 215206

Summary: Support AXCoreObject::elementPath for text elements.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217801
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2020-08-05 18:39:30 PDT 
Support AXCoreObject::elementPath for text elements.
Comment 1 Andres Gonzalez 2020-08-05 18:42:57 PDT 
Created attachment 406066 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-12 18:40:17 PDT 
<rdar://problem/66950893>
Comment 3 Andres Gonzalez 2020-10-12 20:29:56 PDT 
Created attachment 411192 [details]
Patch
Comment 4 chris fleizach 2020-10-12 23:28:34 PDT 
Comment on attachment 411192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411192&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> +                && unionRect.x() - rects[i].x() > xTolerance) {

will this work for RTL languages too?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914
> +                // rect is in a new line and to the left of previous rects

can you make this comment a full sentence
Comment 5 Andres Gonzalez 2020-10-14 08:22:14 PDT 
Created attachment 411324 [details]
Patch
Comment 6 Andres Gonzalez 2020-10-14 08:24:18 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 411192 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411192&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> > +                && unionRect.x() - rects[i].x() > xTolerance) {
> 
> will this work for RTL languages too?

Fixed, checking for rtl text and adjusting check.
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914
> > +                // rect is in a new line and to the left of previous rects
> 
> can you make this comment a full sentence

Fixed.
Comment 7 chris fleizach 2020-10-14 15:08:18 PDT 
Comment on attachment 411324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411324&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> +        for (size_t i = 1; i < rects.size(); ++i) {

can you cache rects.size() outside of the loop
Comment 8 EWS 2020-10-14 15:47:32 PDT 
Committed r268494: <https://trac.webkit.org/changeset/268494>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411324 [details].