Bug 215206

Summary: Support AXCoreObject::elementPath for text elements.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217801
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2020-08-05 18:39:30 PDT
Support AXCoreObject::elementPath for text elements.
Attachments
Patch (3.18 KB, patch)
2020-08-05 18:42 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (9.26 KB, patch)
2020-10-12 20:29 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2020-10-14 08:22 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-08-05 18:42:57 PDT
Created attachment 406066 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-08-12 18:40:17 PDT
<rdar://problem/66950893>
Andres Gonzalez
Comment 3 2020-10-12 20:29:56 PDT
Created attachment 411192 [details] Patch
chris fleizach
Comment 4 2020-10-12 23:28:34 PDT
Comment on attachment 411192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411192&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913 > + && unionRect.x() - rects[i].x() > xTolerance) { will this work for RTL languages too? > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914 > + // rect is in a new line and to the left of previous rects can you make this comment a full sentence
Andres Gonzalez
Comment 5 2020-10-14 08:22:14 PDT
Created attachment 411324 [details] Patch
Andres Gonzalez
Comment 6 2020-10-14 08:24:18 PDT
(In reply to chris fleizach from comment #4) > Comment on attachment 411192 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411192&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913 > > + && unionRect.x() - rects[i].x() > xTolerance) { > > will this work for RTL languages too? Fixed, checking for rtl text and adjusting check. > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914 > > + // rect is in a new line and to the left of previous rects > > can you make this comment a full sentence Fixed.
chris fleizach
Comment 7 2020-10-14 15:08:18 PDT
Comment on attachment 411324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411324&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913 > + for (size_t i = 1; i < rects.size(); ++i) { can you cache rects.size() outside of the loop
EWS
Comment 8 2020-10-14 15:47:32 PDT
Committed r268494: <https://trac.webkit.org/changeset/268494> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411324 [details].
Note You need to log in before you can comment on or make changes to this bug.