| Summary: | MediaElementAudioSourceNode interface should have a constructor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://webaudio.github.io/web-audio-api/#mediaelementaudiosourcenode | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212611 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-08-05 16:24:03 PDT
Created attachment 406059 [details]
Patch
Comment on attachment 406059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406059&action=review > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55 > + context.lazyInitialize(); We could move this after the next if check to keep existing behavior and be more lazy. Committed r265330: <https://trac.webkit.org/changeset/265330> (In reply to youenn fablet from comment #2) > Comment on attachment 406059 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406059&action=review > > > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55 > > + context.lazyInitialize(); > > We could move this after the next if check to keep existing behavior and be > more lazy. Fixed before landing. |