Bug 215196

Summary: Change the system version prefixes to match macOS version numbers
Product: WebKit Reporter: Remy Demarest <rdemarest>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Trivial CC: dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, msaboff, rdemarest, saam, tzagallo
Priority: P2    
Version: Other   
Hardware: Mac   
OS: Other   
Attachments:
Description Flags
Patch
none
Corrected patch including ChangeLogs
none
Patch with style fixes ap: review-, ap: commit-queue-

Remy Demarest
Reported 2020-08-05 15:34:08 PDT
Created attachment 406052 [details] Patch <rdar://problem/66596776>
Attachments
Patch (7.56 KB, patch)
2020-08-05 15:34 PDT, Remy Demarest 		no flags
DetailsFormatted DiffDiff
Corrected patch including ChangeLogs (13.87 KB, patch)
2020-08-05 17:38 PDT, Remy Demarest 		no flags
DetailsFormatted DiffDiff
Patch with style fixes (14.55 KB, patch)
2020-08-06 10:52 PDT, Remy Demarest 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
EWS Watchlist
Comment 1 2020-08-05 15:35:12 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Remy Demarest
Comment 2 2020-08-05 17:38:05 PDT
Created attachment 406061 [details] Corrected patch including ChangeLogs
Remy Demarest
Comment 3 2020-08-06 10:52:43 PDT
Created attachment 406092 [details] Patch with style fixes
Alexey Proskuryakov
Comment 4 2020-08-06 11:47:30 PDT
Comment on attachment 406092 [details] Patch with style fixes This patch doesn't apply, it conflicts with recent removal of 10.16 code. No opinion on the substance of the patch (not obvious to me that it's desirable, but that's because I don't know how SYSTEM_VERSION_PREFIX is used).
Remy Demarest
Comment 5 2020-08-06 11:55:23 PDT
Where can I see the conflicts it creates?
Remy Demarest
Comment 6 2020-08-06 12:35:39 PDT
There is a hard limit on the length of the major version of the framework that we link to WebKit. I'm rescinding this change and bug.
Remy Demarest
Comment 7 2020-08-06 12:36:14 PDT
Marking as NTBF.
Note You need to log in before you can comment on or make changes to this bug.