| Summary: | Change the system version prefixes to match macOS version numbers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Remy Demarest <rdemarest> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Trivial | CC: | dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, msaboff, rdemarest, saam, tzagallo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | Other | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | Other | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Remy Demarest
2020-08-05 15:34:08 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Created attachment 406061 [details]
Corrected patch including ChangeLogs
Created attachment 406092 [details]
Patch with style fixes
Comment on attachment 406092 [details]
Patch with style fixes
This patch doesn't apply, it conflicts with recent removal of 10.16 code.
No opinion on the substance of the patch (not obvious to me that it's desirable, but that's because I don't know how SYSTEM_VERSION_PREFIX is used).
Where can I see the conflicts it creates? There is a hard limit on the length of the major version of the framework that we link to WebKit. I'm rescinding this change and bug. Marking as NTBF. |