| Summary: | Add a createWebArchiveData from a custom scheme API test | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Brady Eidson <beidson> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | darin, thorton, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Brady Eidson
2020-08-05 13:36:43 PDT
Created attachment 406034 [details]
Patch
Comment on attachment 406034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406034&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:72 > + static bool done = false; __block instead of static? Created attachment 406040 [details]
Patch
Created attachment 406042 [details]
Patch
Created attachment 406045 [details]
Patch
Created attachment 406046 [details]
Patch
Created attachment 406049 [details]
Patch
Committed r265310: <https://trac.webkit.org/changeset/265310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406049 [details]. Comment on attachment 406046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406046&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:93 > + [webView loadData:archiveData.get() MIMEType:(NSString *)kUTTypeArchive characterEncodingName:@"utf-8" baseURL:[NSURL URLWithString:@"about:blank"]]; iOS build says: CreateWebArchive.mm:93:62: error: use of undeclared identifier 'kUTTypeArchive' |