| Summary: | Add constructor to ConvolverNode | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | https://webaudio.github.io/web-audio-api/#ConvolverNode | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 212611 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2020-08-05 09:15:28 PDT
Created attachment 406013 [details]
Patch
Comment on attachment 406013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406013&action=review > Source/WebCore/Modules/webaudio/ConvolverNode.cpp:210 > + return Exception { NotSupportedError, "ConvolverNode's channel count cannot greater than 2"_s }; s/channel count cannot greater than 2/channel count cannot be greater than 2/ > Source/WebCore/Modules/webaudio/ConvolverNode.idl:3 > + * Copyright (C) 2020, Apple Inc. All rights reserved. Is there any reason to update this copyright but not the .cpp or .h files? Created attachment 406017 [details]
Patch
Created attachment 406018 [details]
Patch
Committed r265298: <https://trac.webkit.org/changeset/265298> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406018 [details]. |