Bug 215166

Summary: Add a quota delegate test for miniaturized/deminiaturized pages
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2020-08-05 07:17:11 PDT 
Add a quota delegate test for miniaturized/deminiaturized pages
Comment 1 youenn fablet 2020-08-05 07:21:09 PDT 
Created attachment 405996 [details]
Patch
Comment 2 youenn fablet 2020-08-05 09:23:54 PDT 
Created attachment 406006 [details]
Patch
Comment 3 youenn fablet 2020-08-05 10:00:07 PDT 
I added some logging in case this test also fails in Debug Mac bots.
Comment 4 youenn fablet 2020-08-07 07:51:59 PDT 
Ping review
Comment 5 Alex Christensen 2020-08-07 09:11:34 PDT 
Comment on attachment 406006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406006&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:138
> +-(String)receivedMessage {

space before (, { should be on next line.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278
> +    NSLog(@"QuotaDelegateHidden 1");

Why are these here?  Do you think it will time out and you want to see where it does?
Comment 6 youenn fablet 2020-08-07 09:14:58 PDT 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278
> > +    NSLog(@"QuotaDelegateHidden 1");
> 
> Why are these here?  Do you think it will time out and you want to see where
> it does?

Yes, the current StorageQuota delegate tests time out on two debug bots (cannot repro locally though).
Comment 7 youenn fablet 2020-08-07 14:23:08 PDT 
Created attachment 406213 [details]
Patch for landing
Comment 8 EWS 2020-08-08 03:37:09 PDT 
Committed r265406: <https://trac.webkit.org/changeset/265406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406213 [details].
Comment 9 Radar WebKit Bug Importer 2020-08-08 03:38:27 PDT 
<rdar://problem/66721715>
Comment 10 Simon Fraser (smfr) 2020-08-08 08:48:16 PDT 
Comment on attachment 406213 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=406213&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281
> +    NSLog(@"QuotaDelegateHidden 1");

Did you mean to leave in the NSLogging?
Comment 11 youenn fablet 2020-08-08 10:45:05 PDT 
Comment on attachment 406213 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=406213&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281
>> +    NSLog(@"QuotaDelegateHidden 1");
> 
> Did you mean to leave in the NSLogging?

Yes, I am investigating some timeout issues on specific bots in StorageQuota.mm
I plan to remove them once no longer needed.