| Summary: | Introduce a Vector::isolatedCopy() && | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2020-08-05 02:28:13 PDT
Created attachment 405993 [details]
Patch
Comment on attachment 405993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review > Source/WTF/ChangeLog:9 > + This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges. Can we change this at the same time? Comment on attachment 405993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review >> Source/WTF/ChangeLog:9 >> + This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges. > > Can we change this at the same time? RegistrationDatabase::schedulePushChanges already does WTFMove(vector).isolatedCopy() Committed r265369: <https://trac.webkit.org/changeset/265369> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405993 [details]. Looks good! |