| Summary: | AX: WebCore should provide a way to get raw role for accessibility objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Liang <ericliang> | ||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Mac | ||||||
| OS: | macOS 10.15 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Liang
2020-08-04 16:51:03 PDT
Created attachment 405963 [details]
Patch
Comment on attachment 405963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405963&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503 > + return accessibilityRoleToString(self.axBackingObject->roleValue()); what are you going to do with this one since it's not localized? (In reply to chris fleizach from comment #3) > Comment on attachment 405963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405963&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503 > > + return accessibilityRoleToString(self.axBackingObject->roleValue()); > > what are you going to do with this one since it's not localized? This is so in the WebKit iOS bundle I can check the raw roles to add container information. Yea it should not be localized. Committed r265278: <https://trac.webkit.org/changeset/265278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405963 [details]. |