Bug 215138

Summary:

Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	hi: review+
Patch	none

Description Nikita Vasilyev 2020-08-04 14:36:29 PDT

Simplify LTR/RTL CSS code by using logical CSS properties.

This is a follow up for Bug 214563 - Web Inspector: Change DataGrid and Table styles to closer match macOS.

Comment 1 Nikita Vasilyev 2020-08-04 14:38:42 PDT

Created attachment 405943 [details]
Patch

Comment 2 Devin Rousso 2020-08-04 14:43:34 PDT

Comment on attachment 405943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405943&action=review

r=me, awesome!

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:-96
> -body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content {

please double check that removing `body[dir=*]` doesn't cause this to be overridden by some other CSS declaration due to a lower specificity

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:97
> +    border-inline-end: var(--data-grid-column-border-end);

we should inline the `1px solid var(--border-color)` and eliminate `--data-grid-column-border-end` while we're at it too 😃

Comment 3 Nikita Vasilyev 2020-08-04 14:50:46 PDT

Comment on attachment 405943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405943&action=review

>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:-96
>> -body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content {
> 
> please double check that removing `body[dir=*]` doesn't cause this to be overridden by some other CSS declaration due to a lower specificity

Valid concern but there are no other rules that set border on this element.

>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:97
>> +    border-inline-end: var(--data-grid-column-border-end);
> 
> we should inline the `1px solid var(--border-color)` and eliminate `--data-grid-column-border-end` while we're at it too 😃

Makes sense.

Comment 4 Nikita Vasilyev 2020-08-04 14:52:03 PDT

Created attachment 405946 [details]
Patch

Comment 5 EWS 2020-08-04 15:18:26 PDT

Committed r265262: <https://trac.webkit.org/changeset/265262>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405946 [details].

Comment 6 Radar WebKit Bug Importer 2020-08-04 15:19:19 PDT

<rdar://problem/66544335>