Bug 215130

Summary:

Align AudioBufferSourceNode's start() / stop() with the specification

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clark_wang, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

212611

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2020-08-04 10:26:37 PDT

Align AudioBufferSourceNode's start() / stop() with the specification:
- https://www.w3.org/TR/webaudio/#dom-audiobuffersourcenode-start
- https://www.w3.org/TR/webaudio/#dom-audioscheduledsourcenode-stop

Comment 1 Chris Dumez 2020-08-04 10:30:09 PDT

Created attachment 405927 [details]
Patch

Comment 2 Darin Adler 2020-08-04 10:38:46 PDT

Comment on attachment 405927 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405927&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:474
> +        return Exception { InvalidStateError, "Cannot call start more than once." };

Missing _s?

Comment 3 Chris Dumez 2020-08-04 11:03:38 PDT

Created attachment 405931 [details]
Patch

Comment 4 EWS 2020-08-04 12:27:03 PDT

Committed r265256: <https://trac.webkit.org/changeset/265256>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405931 [details].

Comment 5 Radar WebKit Bug Importer 2020-08-04 12:28:21 PDT

<rdar://problem/66536155>