Bug 215104
| Summary: | Reduce use of 'aboutBlankURL().string()' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, dino, esprehn+autocc, ews-watchlist, fmalita, gyuyoung.kim, japhet, kangil.han, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
We should consider making a new immortal string representing "about:blank", like we do for empty string and some others, rather than converting from URL -> String for all of these cases.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
Created attachment 405890 [details]
Patch
Darin Adler
(In reply to Brent Fulgham from comment #0)
> We should consider making a new immortal string representing "about:blank",
> like we do for empty string and some others, rather than converting from URL
> -> String for all of these cases.
Why?
Darin Adler
"Converting" from URL to String is not really a thing. A URL has a String inside it so no conversion is required.
Darin Adler
I don’t think there is benefit here, but maybe I am missing something.
Radar WebKit Bug Importer
<rdar://problem/66803323>
Brent Fulgham
Closing based on Darin's comments.