Bug 215104

Summary:	Reduce use of 'aboutBlankURL().string()'
Product:	WebKit	Reporter:	Brent Fulgham <bfulgham>
Component:	WebCore Misc.	Assignee:	Brent Fulgham <bfulgham>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	benjamin, bfulgham, cdumez, changseok, cmarcelo, darin, dino, esprehn+autocc, ews-watchlist, fmalita, gyuyoung.kim, japhet, kangil.han, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Brent Fulgham 2020-08-03 15:34:26 PDT

We should consider making a new immortal string representing "about:blank", like we do for empty string and some others, rather than converting from URL -> String for all of these cases.

Comment 1 Brent Fulgham 2020-08-03 17:18:02 PDT

Created attachment 405890 [details]
Patch

Comment 2 Darin Adler 2020-08-04 14:42:11 PDT

(In reply to Brent Fulgham from comment #0)
> We should consider making a new immortal string representing "about:blank",
> like we do for empty string and some others, rather than converting from URL
> -> String for all of these cases.

Why?

Comment 3 Darin Adler 2020-08-04 14:42:47 PDT

"Converting" from URL to String is not really a thing. A URL has a String inside it so no conversion is required.

Comment 4 Darin Adler 2020-08-04 14:43:01 PDT

I don’t think there is benefit here, but maybe I am missing something.

Comment 5 Radar WebKit Bug Importer 2020-08-10 15:35:16 PDT

<rdar://problem/66803323>

Comment 6 Brent Fulgham 2020-08-11 11:19:05 PDT

Closing based on Darin's comments.