| Summary: | Remove the ENABLE_DATA_INTERACTION feature flag | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, dino, ews-watchlist, gyuyoung.kim, jbedard, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-08-03 11:19:49 PDT
Created attachment 405855 [details]
For EWS
Comment on attachment 405855 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=405855&action=review > Source/WebCore/page/FocusController.cpp:808 > +#if PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT) I'm assuming there's good reason that some of these are IOS_FAMILY and DRAG_SUPPORT and some are just one or the other. > Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:29 > +#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) nit: would you mind flipping this one so the order matches the others? > Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:874 > +#endif // ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) nit: ditto Comment on attachment 405855 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=405855&action=review >> Source/WebCore/page/FocusController.cpp:808 >> +#if PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT) > > I'm assuming there's good reason that some of these are IOS_FAMILY and DRAG_SUPPORT and some are just one or the other. Yes — some of these places (e.g. WKContentViewInteraction) are already guarded by PLATFORM(IOS_FAMILY), so only ENABLE(DRAG_SUPPORT) is needed, and vice versa. >> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:29 >> +#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) > > nit: would you mind flipping this one so the order matches the others? Good catch! Will do. >> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:874 >> +#endif // ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) > > nit: ditto 👍🏻 Created attachment 405863 [details]
Patch
Committed r265228: <https://trac.webkit.org/changeset/265228> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405863 [details]. |