| Summary: | Add constructor to DelayNode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212611 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-08-03 09:00:46 PDT
Created attachment 405851 [details]
Patch
Comment on attachment 405851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review > Source/WebCore/Modules/webaudio/DelayNode.h:36 > + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); I think DelayOptions parameter is optional, so should provide a default value. Comment on attachment 405851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review >> Source/WebCore/Modules/webaudio/DelayNode.h:36 >> + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); > > I think DelayOptions parameter is optional, so should provide a default value. It is not necessary. Bindings are smart enough to always pass us a default-initialized dictionary. (In reply to Chris Dumez from comment #3) > Comment on attachment 405851 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405851&action=review > > >> Source/WebCore/Modules/webaudio/DelayNode.h:36 > >> + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); > > > > I think DelayOptions parameter is optional, so should provide a default value. > > It is not necessary. Bindings are smart enough to always pass us a > default-initialized dictionary. Ah interesting, I'll take this into account for my future patches as well. Committed r265221: <https://trac.webkit.org/changeset/265221> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405851 [details]. |