Bug 215077

Summary: run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: angelos, ap, keith_miller, ticaiolima, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zhifei Fang 2020-08-03 01:30:53 PDT 
run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
Comment 1 Zhifei Fang 2020-08-03 01:31:18 PDT 
Created attachment 405819 [details]
Patch
Comment 2 Zhifei Fang 2020-08-03 01:31:51 PDT 
rdar://66451802
Comment 3 Zhifei Fang 2020-08-03 01:32:50 PDT 
break by this change:

https://bugs.webkit.org/show_bug.cgi?id=214356
Comment 4 Zhifei Fang 2020-08-03 01:34:19 PDT 
Hi, Angelos

Any special reason to escape the DYLD_FRAMEWORK_PATH ?
Comment 5 EWS 2020-08-03 10:30:58 PDT 
Committed r265204: <https://trac.webkit.org/changeset/265204>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405819 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-03 13:37:44 PDT 
<rdar://problem/66489295>
Comment 7 Caio Lima 2020-08-05 04:15:43 PDT 
(In reply to Zhifei Fang from comment #4)
> Hi, Angelos
> 
> Any special reason to escape the DYLD_FRAMEWORK_PATH ?

Hi Zhifei. Angelos is on holidays now and he couldn't answer it on time. This change caused some issues to gnu-parallel-runner configuration (It is possible to see it on EWS ARMv7 and MIPS run):

```
/bin/bash: -c: line 0: syntax error near unexpected token `('
/bin/bash: -c: line 0: `cd jsc-stress-results/.runner && export DYLD_FRAMEWORK_PATH=\$(cd ../.vm; pwd) && export LD_LIBRARY_PATH=\$(pwd)/jsc-stress-results/.vm/JavaScriptCore.framework/Helpers &&export JSCTEST_timeout=1200 && export JSCTEST_hardTimeout=300 && export JSCTEST_memoryLimit=838860800 && export TZ=US/Pacific && sh  ./test_script_25617'
```

IIUC, this change was necessary to allow Make runner work again for remote devices, right? I'm not very familiar with this part of the code and with pearl, so I don't want to make too much assumptions there.

In the meantime, I changed configuration of those bots to use Make runner instead of gnu-parallel, so we can process EWS and post-commit bots queues.
Comment 8 Angelos Oikonomopoulos 2020-08-27 08:33:36 PDT 
(In reply to Zhifei Fang from comment #4)
> Hi, Angelos
> 
> Any special reason to escape the DYLD_FRAMEWORK_PATH ?

Hi Zhifei,

the reason was I was using different kind of quoting when invoking GNU parallel. See https://bugs.webkit.org/show_bug.cgi?id=215887 for a suggested fix.