| Summary: | REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
| Component: | Tools / Tests | Assignee: | BJ Burg <bburg> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
BJ Burg
2020-07-31 15:28:07 PDT
Created attachment 405750 [details]
Patch
Comment on attachment 405750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405750&action=review > Tools/Scripts/webkitpy/results/options.py:34 > + optparse.make_option('--' + suite_name_flag, help='Optional flag for overriding reported suite name.', default=None), Note that since the caller of this will be the bit using the flag, we don't need to try anything fancy to change how we consume the flag, that's up to the code instantiation the options. Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog Created attachment 405836 [details]
Patch
Committed r265201: <https://trac.webkit.org/changeset/265201> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405836 [details]. |