| Summary: | [WebGL2] Upgrade vertexAttribPointer with new supported types | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 126938, 214211 | ||||||||||
| Bug Blocks: | 126404 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kenneth Russell
2020-07-31 15:14:42 PDT
When this is fixed, let's make sure to test with the Filament team's test case to see whether it's working. Created attachment 405886 [details]
Patch
This doesn't appear to be tested at all by the conformance tests as far as I can tell. I'm working on adding some tests. Created attachment 405894 [details]
Patch
Confirmed that this fixes the Filament test case :) Comment on attachment 405894 [details]
Patch
Looks good!
Comment on attachment 405894 [details]
Patch
Can we get a test (or WebGL conformance test) for this?
Comment on attachment 405894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405894&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please note here that a test is coming in the WebGL suite. Created attachment 406062 [details]
add tests
Comment on attachment 406062 [details]
add tests
I went ahead and updated the conformance tests.
Comment on attachment 406062 [details]
add tests
Looks good - thanks for patching up the conformance tests James!
Committed r265317: <https://trac.webkit.org/changeset/265317> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406062 [details]. |