| Summary: | Convert LinkHeader to use StringParsingBuffer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, ews-watchlist, japhet, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2020-07-31 07:36:39 PDT
Created attachment 405692 [details]
Patch
Comment on attachment 405692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405692&action=review > Source/WebCore/loader/LinkHeader.cpp:54 > - if ((chr >= '^' && chr <= 'z') || (chr >= 'A' && chr <= 'Z') || (chr >= '0' && chr <= '9') || (chr >= '!' && chr <= '$') || chr == '&' || chr == '+' || chr == '-' || chr == '.') > + if ((character >= '^' && character <= 'z') || (character >= 'A' && character <= 'Z') || (character >= '0' && character <= '9') || (character >= '!' && character <= '$') || character == '&' || character == '+' || character == '-' || character == '.') > return true; > return false; I’d like to see this be made shorter by using isASCIIAlphanumeric. Also, I’d like to use return rather than if return true else return false. Committed r265177: <https://trac.webkit.org/changeset/265177> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405692 [details]. |