| Summary: | Move user gesture propagation over promise behind a feature flag | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, jer.noble, jiewen_tan, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-07-31 00:33:23 PDT
Created attachment 405675 [details]
Patch
Created attachment 405679 [details]
Patch
Created attachment 405686 [details]
Patch
Hi Youenn, Making user gesture being able to propagate through Fetch API is an important fix for this year's WebAuthn release. Can we have this feature turned on by default? Or we could make another scope just for WebAuthn. Is there any reasons you feel unsafe to turn on this feature? > Is there any reasons you feel unsafe to turn on this feature?
Do you know if we are matching Mozilla behavior for fetch?
I guess we can turn on the feature for fetch and response getters.
Some things in the implementation could be ironed out there but this should be fine.
For ReadableStream, I think we should consolidate this and probably write a spec or at least get some discussion broader than WebKit.
Comment on attachment 405686 [details]
Patch
Didn't see this is enabled for WebKitTestRunner, but surprisedly WK2 bots are green.
Created attachment 405893 [details]
Patch for landing
(In reply to Jiewen Tan from comment #7) > Created attachment 405893 [details] > Patch for landing After talking to Youenn, he agrees to make the feature default on. Therefore, uploaded a patch with that. Committed r265235: <https://trac.webkit.org/changeset/265235> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405893 [details]. |