Bug 215013

Summary: Clean up text layout code a bit
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206208    
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Description Myles C. Maxfield 2020-07-30 22:43:30 PDT 
Clean up text layout code a bit
Comment 1 Myles C. Maxfield 2020-07-30 22:56:48 PDT 
Created attachment 405671 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-07-30 22:57:35 PDT 
<rdar://problem/66365710>
Comment 3 Myles C. Maxfield 2020-07-30 23:03:56 PDT 
Created attachment 405672 [details]
Patch
Comment 4 zalan 2020-07-31 16:59:01 PDT 
Comment on attachment 405672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405672&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1391
> +    float initialAdvance;

I always get scared when I see a non-initialized variable (I know it gets a value eventually).
Comment 5 Myles C. Maxfield 2020-07-31 17:36:19 PDT 
Committed r265170: <https://trac.webkit.org/changeset/265170>