| Summary: | [webkitpy] Use webkitcorepy's auto installer for requests | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214950 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jonathan Bedard
2020-07-29 17:26:45 PDT
Created attachment 405545 [details]
Patch
Comment on attachment 405545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405545&action=review > Tools/Scripts/webkitpy/thirdparty/__init__.py:86 > + sys.path.insert(1 if 'libraries/autoinstalled' in sys.path[0] else 0, _AUTOINSTALLED_DIR) Needed for compatibility. webkitpy cannot override webkitcorepy since webkitcorepy is, in some cases, uses more updated versions of the auto-installed libraries. We also don't want to require existing checkouts to delete their webkitpy auto install directory. Created attachment 405546 [details]
Patch
Created attachment 405568 [details]
Patch
Created attachment 405659 [details]
Patch
Comment on attachment 405659 [details] Patch Blocking this on <https://bugs.webkit.org/show_bug.cgi?id=215067>, since that problem more correctly solves some of the issues this patch attempts to. Created attachment 405954 [details]
Patch
Created attachment 405962 [details]
Patch
Committed r265574: <https://trac.webkit.org/changeset/265574> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405954 [details]. |