Bug 214934

Summary:

[GTK] 2.29.4 fails to link on armv7hl

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, bugs-noreply, clopez, dino, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Michael Catanzaro 2020-07-29 14:23:59 PDT

I'm not sure what changed, but 2.29.4 doesn't link on ARM:

/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::GetHelperExecutableDir[abi:cxx11]()':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:64: undefined reference to `dladdr'
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::getSymbol(char const*)':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:98: undefined reference to `dlsym'
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::~PosixLibrary()':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:87: undefined reference to `dlclose'
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::~PosixLibrary()':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:87: undefined reference to `dlclose'
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::PosixLibrary(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:75: undefined reference to `dlopen'
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::PosixLibrary(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:79: undefined reference to `dlerror'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Comment 1 Michael Catanzaro 2020-07-29 14:24:51 PDT

Created attachment 405501 [details]
Patch

Comment 2 EWS Watchlist 2020-07-29 14:25:50 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Comment 3 EWS 2020-07-29 16:57:07 PDT

Committed r265070: <https://trac.webkit.org/changeset/265070>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405501 [details].