| Summary: | REGRESSION(r264476): Calling systemHasAC() regresses launch time performance | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, dewei_zhu, eric.carlson, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2020-07-28 19:28:06 PDT
Created attachment 405434 [details]
Patch
Comment on attachment 405434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405434&action=review > Source/WebCore/platform/cocoa/PowerSourceNotifier.mm:44 > if (status == NOTIFY_STATUS_OK) > m_tokenID = token; If notify_register_dispatch failed, should this just return early instead of potentially calling notifyPowerSourceChanged()? (In reply to Eric Carlson from comment #3) > Comment on attachment 405434 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405434&action=review > > > Source/WebCore/platform/cocoa/PowerSourceNotifier.mm:44 > > if (status == NOTIFY_STATUS_OK) > > m_tokenID = token; > > If notify_register_dispatch failed, should this just return early instead of > potentially calling notifyPowerSourceChanged()? I don't think so. Even if the register command fails, we'll still want to update the AC state next run loop. Committed r265056: <https://trac.webkit.org/changeset/265056> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405434 [details]. |