Bug 214902

Summary: Move non standard OscillatorNode API to new webKitOscillatorNode interface
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, clark_wang, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214925
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-07-28 15:51:08 PDT
Move non standard OscillatorNode API to new WebKitOscillatorNode interface, so that the unprefixed OscillatorNode is fully spec-compliant.
Comment 1 Chris Dumez 2020-07-28 17:09:53 PDT
Created attachment 405428 [details]
Patch
Comment 2 Darin Adler 2020-07-28 17:19:33 PDT
Comment on attachment 405428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405428&action=review

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:32
> +class WebKitOscillatorNode : public OscillatorNode {

final

> Source/WebCore/Modules/webaudio/WebKitOscillatorNode.h:46
> +    const char* activeDOMObjectName() const final { return "WebKitOscillatorNode"; }

private
Comment 3 Chris Dumez 2020-07-28 18:25:06 PDT
Created attachment 405431 [details]
Patch
Comment 4 EWS 2020-07-28 22:18:39 PDT
Committed r265028: <https://trac.webkit.org/changeset/265028>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405431 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-28 22:19:21 PDT
<rdar://problem/66255126>