| Summary: | Migrate App-Bound Domains code from WebKit Additions | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||||||||||||||||||||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, bfulgham, commit-queue, webkit-bot-watchers-bugzilla | ||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214916 | ||||||||||||||||||||||||||||
| Bug Depends on: | 214917 | ||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Kate Cheney
2020-07-28 12:24:36 PDT
Created attachment 405399 [details]
Patch
Created attachment 405400 [details]
Patch
Created attachment 405402 [details]
Patch
Created attachment 405405 [details]
Patch
Created attachment 405406 [details]
Patch
Created attachment 405409 [details]
Patch
Created attachment 405411 [details]
Patch
Having some trouble making EWS happy, hopefully this one does it... Created attachment 405414 [details]
Patch
Created attachment 405419 [details]
Patch
Comment on attachment 405419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405419&action=review r=me, but please correct the ChangeLog that includes Ryan's description, too. > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192 > + @"NSRemindersUsageDescription", Can you please remove the "NSRemindersUsageDescription", we are not restricting this one anymore. > LayoutTests/ChangeLog:11 > + Oops! Two ChangeLog entries. (In reply to Brent Fulgham from comment #12) > Comment on attachment 405419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405419&action=review > > r=me, but please correct the ChangeLog that includes Ryan's description, too. > Whoops -- accidentally absorbed that along the way. Will fix. > > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192 > > + @"NSRemindersUsageDescription", > Yes, will do. > Can you please remove the "NSRemindersUsageDescription", we are not > restricting this one anymore. > > > LayoutTests/ChangeLog:11 > > + > > Oops! Two ChangeLog entries. Good catch! Created attachment 405422 [details]
Patch for landing
Committed r265018: <https://trac.webkit.org/changeset/265018> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405422 [details]. This (In reply to EWS from comment #15) > Committed r265018: <https://trac.webkit.org/changeset/265018> This seems to have broken various ios-wk2 tests. Tracked in Bug 214916. Please make sure to run the patches through EWS before landing. In this case there were 10 patches uploaded within ~2 hours, and none of the patches were run through ios-wk2, api-ios, mac-debug-wk1, win EWSes. Re-opened since this is blocked by bug 214917 Created attachment 405476 [details]
Patch
Thanks Aakash -- my bad on not letting EWS finish. I am unable to reproduce these failures locally, so I am uploading this patch with some logging to try and figure out what is going on on EWS. Created attachment 405484 [details]
Patch
Comment on attachment 405484 [details]
Patch
r=me
Committed r265063: <https://trac.webkit.org/changeset/265063> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405484 [details]. |