Bug 214859

Summary:

Clicking on a shadow DOM does not move the selection to the focused element when delegatesFocus is set to true

Product:

WebKit

Reporter:

Jan Miksovsky <jan>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, esprehn+autocc, ews-watchlist, kangil.han, koivisto, rniwa, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=166484

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
Fixes the bug	none

Description Jan Miksovsky 2020-07-27 16:41:18 PDT

Although WebKit has implemented support for the delegatesFocus flag (https://bugs.webkit.org/show_bug.cgi?id=166484), the implementation appears to be incomplete.

To repro, use the same repro from the above bug: https://bug-166484-attachments.webkit.org/attachment.cgi?id=297772

* Clicking the "Hello world" text should focus the input. The input gets a focus ring, but does not appear to have the focus -- you can't type in the input, for example.
* Programmatically invoking the focus() method on that element similarly doesn't not focus the input.

Comment 1 Radar WebKit Bug Importer 2020-07-27 18:19:38 PDT

<rdar://problem/66192901>

Comment 2 Ryosuke Niwa 2020-07-30 02:36:54 PDT

Created attachment 405559 [details]
Fixes the bug

Comment 3 EWS 2020-07-30 13:14:30 PDT

Committed r265092: <https://trac.webkit.org/changeset/265092>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405559 [details].