| Summary: | [Big Sur] Wrap SPI in feature guards | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | WebCore Misc. | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, darin, saagar, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214707 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-07-27 13:05:08 PDT
Created attachment 405306 [details]
Patch
Comment on attachment 405306 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405306&action=review > Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39 > extern const NSImageHintKey NSImageHintSymbolFont; Pre-existing issue, but this shouldn't be in #else, correct? We want the compiler to tell us if the type is incorrect. Created attachment 405307 [details]
Patch
Committed r264946: <https://trac.webkit.org/changeset/264946> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405307 [details]. Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes build errors :( I'll put up a new patch to move it back into. Reopening to attach new patch. Created attachment 405413 [details]
Patch for landing
(In reply to Saagar Jha from comment #6) > Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes > build errors :( I'll put up a new patch to move it back into. Oops! Build fix incoming. Bots will be up for Seed 3 shortly, so we'll be more formally defending this build. Committed r265010: <https://trac.webkit.org/changeset/265010> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405413 [details]. |