Bug 214823

Summary:	[ews] Make buildbot try robust against network issues
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	ASSIGNED ---
Severity:	Normal	CC:	aakash_jain, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Aakash Jain 2020-07-27 06:06:32 PDT

We should make 'buildbot try' commmand (run by ews django app to send patches to Buildbot) robust against network issues. For e.g. if Buildbot server is down for any reason (e.g: rebooting), any patches sent by ews django app (using buildbot try command) would be lost. This is because it isn't able to detect a failure in 'buildbot try' command. This is due to a bug in Buildbot (that the exit code of 'buildbot try' command is zero both in case of success and failure, see https://github.com/buildbot/buildbot/issues/4837).

We should improve the failure detection logic for Buildbot try command, and retry the command when it fails. This would make EWS Django app robust against network issues and buildbot restarts.

Comment 1 Radar WebKit Bug Importer 2020-07-27 06:06:58 PDT

<rdar://problem/66158707>