Bug 214807

Summary: [Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, jbedard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2020-07-26 11:43:26 PDT
[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
Attachments
Patch (20.95 KB, patch)
2020-07-26 11:52 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-07-26 11:52:23 PDT
Created attachment 405255 [details] Patch
Darin Adler
Comment 2 2020-07-26 11:58:37 PDT
Comment on attachment 405255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405255&action=review > Source/WebCore/ChangeLog:16 > + * platform/graphics/cocoa/VP9UtilitiesCocoa.h: > + * platform/graphics/cocoa/VP9UtilitiesCocoa.mm: > + (WebCore::registerWebKitVP9Decoder): I would have left the word "utilities" out of this file’s name. > Source/WebCore/SourcesCocoa.txt:359 > +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify Is this *really* necessary? Why?
Jer Noble
Comment 3 2020-07-26 22:34:06 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 405255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405255&action=review > > > Source/WebCore/ChangeLog:16 > > + * platform/graphics/cocoa/VP9UtilitiesCocoa.h: > > + * platform/graphics/cocoa/VP9UtilitiesCocoa.mm: > > + (WebCore::registerWebKitVP9Decoder): > > I would have left the word "utilities" out of this file’s name. > > > Source/WebCore/SourcesCocoa.txt:359 > > +platform/graphics/cocoa/VP9UtilitiesCocoa.mm @no-unify > > Is this *really* necessary? Why? Yes. Some header in CoreServices adds `a #define kName ...`, which causes a compilation error when a header inside WebRTC defines variable with that same name. And the CoreServices header just happens to be pulled into the unified build by some sibling source file.
EWS
Comment 4 2020-07-30 14:28:43 PDT
Committed r265095: <https://trac.webkit.org/changeset/265095> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405255 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-30 14:29:18 PDT
<rdar://problem/66347767>
Note You need to log in before you can comment on or make changes to this bug.