| Summary: | libwebrtc uint64_t build fixes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||
| Component: | WebRTC | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, darin, eric.carlson, ews-watchlist, glenn, jan.brummer, jer.noble, mcatanzaro, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
Created attachment 405252 [details]
Patch
(I wonder if anyone here has an account on libwebrtc's gerrit and would be willing to send it upstream...?) Created attachment 405253 [details]
Patch
Would be good to upstream otherwise this might get overwritten at next resync. Committed r264904: <https://trac.webkit.org/changeset/264904> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405253 [details]. (In reply to Michael Catanzaro from comment #2) > (I wonder if anyone here has an account on libwebrtc's gerrit and would be > willing to send it upstream...?) (In reply to youenn fablet from comment #4) > Would be good to upstream otherwise this might get overwritten at next > resync. As per https://bugs.webkit.org/show_bug.cgi?id=218436, this actually happened. If you cannot upstream the changes, please add #if defined(WEBRTC_WEBKIT_BUILD) so that there is a chance to keep these changes at next resync. OK |
WebKitGTK currently fails to build with -DENABLE_EXPERIMENTAL_FEATURES=ON because a bunch of libwebrtc headers use integer typedefs without declaring them: In file included from ../../Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h264/pps_parser.cc:11: ../../Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h264/pps_parser.h:33:5: error: ‘uint32_t’ does not name a type; did you mean ‘u_int32_t’? 33 | uint32_t weighted_bipred_idc = false; | ^~~~~~~~ | u_int32_t