Bug 214762

Summary: Remove unused WebGL 2.0-related methods
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: dino, jdarpinian, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    

Description Kenneth Russell 2020-07-24 14:49:19 PDT
Some methods in GraphicsContextGL and WebGL2RenderingContext exist only for the non-ANGLE code path. Since WebGL 2.0 is infeasible to implement without ANGLE, and has already been disabled for the non-ANGLE code path (!USE(ANGLE)), these methods and overrides should be removed.
Comment 1 Kenneth Russell 2020-07-24 14:50:45 PDT
As one example, WebGLRenderingContextBase::validateIndexArrayConservative should be removed from the non-ANGLE code path, and the override removed from WebGL2RenderingContext.
Comment 2 Radar WebKit Bug Importer 2020-07-31 14:50:18 PDT
<rdar://problem/66399743>
Comment 3 Kenneth Russell 2020-08-07 16:06:07 PDT
After more thought, fixing up the remaining WebGL 2.0 conformance issues is higher priority than this cleanup. Downgrading to P3 and unassigning myself for the moment.