| Summary: | KeyframeEffect doesn't update after changing timing function | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED WORKSFORME | ||||||
| Severity: | Normal | CC: | dino, graouts, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214712 | ||||||
| Attachments: |
|
||||||
KeyframeEffect::animationDidChangeTimingProperties() needs to call computeSomeKeyframesUseStepsTimingFunction(). The attached test works fine for me on a ToT build on macOS. When the spinner is not hovered, it progresses very slowly step-by-step while when it's hovered it has a linear animation. I didn't see any obvious difference between its behavior on a ToT build and recent Firefox and Chrome. https://trac.webkit.org/changeset/264856/webkit fixed this. |
Created attachment 405088 [details] test In the attached test, hover the spinner. This should change the timing function, but the same KeyframeEffect persists, and KeyframeEffect::computeSomeKeyframesUseStepsTimingFunction() is never called.