| Summary: | Tapping QuickType suggestions for a misspelled word does nothing in Mail compose | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | darin, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Wenson Hsieh
2020-07-23 15:13:56 PDT
Created attachment 405085 [details]
Patch
Created attachment 405086 [details]
Fix non-internal iOS build
Comment on attachment 405086 [details] Fix non-internal iOS build View in context: https://bugs.webkit.org/attachment.cgi?id=405086&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770 > + completionHandler(); Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called) Comment on attachment 405086 [details] Fix non-internal iOS build View in context: https://bugs.webkit.org/attachment.cgi?id=405086&action=review >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770 >> + completionHandler(); > > Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called) makeScopeExit (In reply to Darin Adler from comment #4) > Comment on attachment 405086 [details] > Fix non-internal iOS build > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405086&action=review > > >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1770 > >> + completionHandler(); > > > > Does this want some kind of call-at-exit thing? (I feel like we have one, but not sure what it's called) > > makeScopeExit 👍🏻 Created attachment 405095 [details]
Minor tweaks
Created attachment 405107 [details]
Fix API test
Created attachment 405122 [details]
Fix API test
Committed r264812: <https://trac.webkit.org/changeset/264812> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405122 [details]. |