Bug 214702

Summary: Crash in block in WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cdumez: review+
Patch none

Description Per Arne Vollan 2020-07-23 15:00:19 PDT 
Calling xpc_connection_send_message in the block in WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver will sometimes crash because the XPC connection object is invalid.
Comment 1 Per Arne Vollan 2020-07-23 15:00:50 PDT 
rdar://problem/65879665
Comment 2 Per Arne Vollan 2020-07-23 15:28:13 PDT 
Created attachment 405084 [details]
Patch
Comment 3 Chris Dumez 2020-07-23 15:50:09 PDT 
Comment on attachment 405084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405084&action=review

> Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.h:59
> +    Lock m_lock;

I think I would call this m_connectionsLock for clarity.
Comment 4 Per Arne Vollan 2020-07-23 15:54:09 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 405084 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405084&action=review
> 
> > Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.h:59
> > +    Lock m_lock;
> 
> I think I would call this m_connectionsLock for clarity.

Will do.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-07-23 16:00:15 PDT 
Created attachment 405090 [details]
Patch
Comment 6 EWS 2020-07-23 16:54:27 PDT 
Committed r264806: <https://trac.webkit.org/changeset/264806>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405090 [details].