Bug 214694

Summary:

[ iOS wk2 ] imported/w3c/web-platform-tests/web-share/share-without-user-gesture.https.html is a constant timeout

Product:

WebKit

Reporter:

Karl Rackler <rackler>

Component:

New Bugs

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, cdumez, darin, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Karl Rackler 2020-07-23 11:02:07 PDT

Description:
imported/w3c/web-platform-tests/web-share/share-without-user-gesture.https.html

This issue started after https://trac.webkit.org/changeset/264564/webkit .
History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fweb-share%2Fshare-without-user-gesture.https.html&platform=ios&limit=50000&flavor=wk2

Diff:
Diff link (https://build.webkit.org/results/Apple%20iPadOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r264751%20(2920)/imported/w3c/web-platform-tests/web-share/share-without-user-gesture.https-diff.txt) results in 'No Such Resource File not found.'

Comment 1 Radar WebKit Bug Importer 2020-07-23 11:02:45 PDT

<rdar://problem/66001110>

Comment 2 Karl Rackler 2020-07-23 11:20:30 PDT

I have marked this test as timeout while this issue is investigated.
https://trac.webkit.org/changeset/264777/webkit

Comment 3 Chris Dumez 2020-07-23 13:48:02 PDT

Issue does not seem caused by the test itself:
TestController::platformResetPreferencesToConsistentValues - Failed to remove presented view controller
#PROCESS UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 19216)

Comment 4 Ryan Haddad 2020-07-23 15:27:17 PDT

Switched the flaky timeout expectation to a skip in rr264798

Comment 5 Chris Dumez 2020-07-23 15:58:42 PDT

Created attachment 405089 [details]
Patch

Comment 6 Chris Dumez 2020-07-23 17:25:52 PDT

Created attachment 405102 [details]
Patch

Comment 7 Chris Dumez 2020-07-23 17:26:39 PDT

(In reply to Chris Dumez from comment #6)
> Created attachment 405102 [details]
> Patch

Improved fix after talking to our Web Share expert (Tim Horton).

Comment 8 EWS 2020-07-23 21:41:14 PDT

Found 4 new test failures: fast/web-share/share-transient-activation.html, fast/web-share/share-with-files.html, fast/web-share/share-with-no-url.html, fast/web-share/share.html

Comment 9 Chris Dumez 2020-07-24 08:58:10 PDT

Created attachment 405148 [details]
Patch

Comment 10 EWS 2020-07-24 09:45:00 PDT

Committed r264834: <https://trac.webkit.org/changeset/264834>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405148 [details].