| Summary: | Update the isolated tree even when there is no client request. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-07-23 10:51:50 PDT
Created attachment 405060 [details]
Patch
Comment on attachment 405060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405060&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:3196 > + case AXLoadingFinished: can we change this method so it doesn't duplicate the logic in the other updateIsolateTree method? instead do something like void AXObjectCache::updateIsolatedTree(AXCoreObject& object, AXLoadingEvent notification) { if (notification == AXLoadingFinished) updateIsoaltedTree(object, AXChildrenChanged) } Created attachment 405064 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 405060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405060&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:3196 > > + case AXLoadingFinished: > > can we change this method so it doesn't duplicate the logic in the other > updateIsolateTree method? instead do something like > > void AXObjectCache::updateIsolatedTree(AXCoreObject& object, AXLoadingEvent > notification) > { > if (notification == AXLoadingFinished) > updateIsoaltedTree(object, AXChildrenChanged) > } Done as suggested. Also pondered the approach of merging the AXLoadingEvent enum into AXNotification. But don't know why it was added as a separate enum, and it would require more changes. Something perhaps for a later cleanup. Thanks. Committed r264784: <https://trac.webkit.org/changeset/264784> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405064 [details]. |