Bug 214666

Summary:

[Cocoa|WebM] Decode error when seeking

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, peng.liu6, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+
Patch for landing	none

Description Jer Noble 2020-07-22 17:18:10 PDT

[Cocoa|WebM] Decode error when seeking

Comment 1 Jer Noble 2020-07-22 17:22:13 PDT

<rdar://problem/65961804>

Comment 2 Jer Noble 2020-07-22 17:22:32 PDT

Created attachment 404999 [details]
Patch

Comment 3 Eric Carlson 2020-07-22 18:03:36 PDT

Comment on attachment 404999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404999&action=review

> Source/WebCore/ChangeLog:8
> +        A decoder error is hit when seeking because we think all samples coming out of the SourceBufferParserWebM is a sync-sample.

There is a tense problem here: "all samples ... is a sync-sample"

Comment 4 Jer Noble 2020-07-22 18:07:05 PDT

Created attachment 405003 [details]
Patch for landing

Comment 5 EWS 2020-07-22 20:01:29 PDT

Committed r264742: <https://trac.webkit.org/changeset/264742>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405003 [details].