| Summary: | Update macOS Version macros | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Conrad Shultz <conrad_shultz> | ||||||
| Component: | New Bugs | Assignee: | Conrad Shultz <conrad_shultz> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, benjamin, cdumez, cmarcelo, dino, eric.carlson, ews-watchlist, graouts, jbedard, keith_miller, kondapallykalyan, mark.lam, msaboff, rniwa, saam, thorton, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Conrad Shultz
2020-07-22 13:56:13 PDT
Created attachment 404960 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Created attachment 404983 [details]
Patch
Comment on attachment 404983 [details]
Patch
This is somewhere between rs=me and r=me.
Committed r264746: <https://trac.webkit.org/changeset/264746> Comment on attachment 404983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404983&action=review > Source/JavaScriptCore/Configurations/Base.xcconfig:109 > TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600; Do we still need these? (In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 404983 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404983&action=review > > > Source/JavaScriptCore/Configurations/Base.xcconfig:109 > > TARGET_MAC_OS_X_VERSION_MAJOR_10_16 = 101600; > > Do we still need these? I'm leaving them in for now in case anyone builds on, e.g., the first seed of Big Sur. I'd think we can remove them in due course. |