Bug 214649

Summary: updateRendering trace point should exclude SVG
Product: WebKit Reporter: Ben Nham <nham>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ben Nham 2020-07-22 12:12:15 PDT 
After r259830, the updateRendering tracepoint doesn't work as expected since we are calling the tracepoint reentrantly (the root page's Page::updateRendering calls the SVG page's Page::updateRendering). We should either exclude the SVG page from this tracepoint or change the tracepoint pass an extra arg to kdebug_trace that can be used to properly pair the beginning and end of the tracepoint.
Comment 1 Simon Fraser (smfr) 2020-07-23 10:31:50 PDT 
*** Bug 214691 has been marked as a duplicate of this bug. ***
Comment 2 Simon Fraser (smfr) 2020-07-23 10:32:25 PDT 
Created attachment 405055 [details]
Patch
Comment 3 Geoffrey Garen 2020-07-23 10:34:37 PDT 
Comment on attachment 405055 [details]
Patch

r=me
Comment 4 EWS 2020-07-23 11:25:25 PDT 
Committed r264778: <https://trac.webkit.org/changeset/264778>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405055 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-23 11:26:17 PDT 
<rdar://problem/66002353>