| Summary: | [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Caio Lima
2020-07-22 07:29:35 PDT
Created attachment 404921 [details]
Patch
Comment on attachment 404921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404921&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:331 > + move UndefinedTag, r1 > + move 0, r0 Can you just put a comment above this that says that this is in little endian order? That will make it easier if anyone tries to make big endian work, and need to grep for search for places to make needed changes. A comment is cheap and can be so helpful here. Created attachment 405033 [details]
Patch
Comment on attachment 405033 [details]
Patch
Thank you very much for the review. I also added another comment in another place that is "little-endian" specific.
Committed r264758: <https://trac.webkit.org/changeset/264758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405033 [details]. |