Bug 214640
| Summary: | sRGB render targets not working | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | jujjyl |
| Component: | WebGL | Assignee: | Kenneth Russell <kbr> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dino, jdarpinian, jonlee, kbr, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 13 | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 212277, 215844, 215973 | ||
| Bug Blocks: | |||
jujjyl
STR:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/ext-sRGB.html?webglVersion=1&quiet=0&quick=1
Fails on two subsections
"Test the conversion of colors from linear to sRGB_ALPHA on framebuffer (texture) write"
"Test the conversion of colors from linear to sRGB on framebuffer (renderbuffer) write"
on macOS and iOS. We suspect that this causes incorrect brightness in rendering e.g. in Tiny Unity demo at
https://tiny.vision/demos/TinyRacing/Wasm/TinyRacing.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
jujjyl
It looks like the same issue occurs on both WebGL 1 contexts when using the EXT_sRGB extension, and WebGL 2 contexts.
Radar WebKit Bug Importer
<rdar://problem/65940663>
Kenneth Russell
This has been fixed in Safari Technology Preview (Safari 14) with the ANGLE backend, likely via Bug 212277. Jukka, can you please confirm?
Kenneth Russell
One of the earlier Safari Technology Previews ran Tiny Racing successfully, but the current one on macOS (Release 112 (Safari 14.0, WebKit 15610.1.25.5.1)) does have a regression where Tiny Racing renders black.
jdarpinian@ fixed two recent related bugs:
Implement WEBGL_compressed_texture_s3tc_srgb extension
https://bugs.webkit.org/show_bug.cgi?id=215973
and
WebGL goes in a bad state where glContext.createProgram() returns null
https://bugs.webkit.org/show_bug.cgi?id=215844
with those two fixes, top-of-tree WebKit at r266786 runs both Tiny Racing and https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/ext-sRGB.html?webglVersion=1 successfully.
Closing this report as WontFix since other bugs resolved it.