| Summary: | Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, dino, hi, inspector-bugzilla-changes, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
BJ Burg
2020-07-21 15:53:17 PDT
Created attachment 404870 [details]
Patch
Comment on attachment 404870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review r=me > LayoutTests/inspector/canvas/memory.html:59 > + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check Comment on attachment 404870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review >> LayoutTests/inspector/canvas/memory.html:59 >> + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); > > NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check It.. is. see expected results for the first test case. Committed r264683: <https://trac.webkit.org/changeset/264683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404870 [details]. |