| Summary: | [GTK] GeoclueGeolocationProvider uses very low accuracy setting (city) as default geolocation API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris McGee <newton688> | ||||||
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, clopez, pnormand | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris McGee
2020-07-20 12:53:23 PDT
Created attachment 405266 [details]
Patch
Comment on attachment 405266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405266&action=review > Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp:244 > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 4; You have only changed the comment, I guess this should be: unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 6; no? (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 405266 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405266&action=review > > > Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp:244 > > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 4; > > You have only changed the comment, I guess this should be: > > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 6; > > no? Indeed, I'll post an updated patch 🤦️ Created attachment 405268 [details]
Patch v2
Committed r264920: <https://trac.webkit.org/changeset/264920> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405268 [details]. |