Bug 214555

Summary:

pluginElementCustomGetOwnPropertySlot() should support VMInquiry requests.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

WebCore JavaScript

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none
proposed patch.	ysuzuki: review+

Description Mark Lam 2020-07-20 09:42:27 PDT

<rdar://problem/65625807>

Comment 1 Mark Lam 2020-07-20 17:07:36 PDT

<rdar://problem/65855400>

Comment 2 Mark Lam 2020-07-24 21:25:05 PDT

Created attachment 405220 [details]
proposed patch.

Comment 3 Mark Lam 2020-07-24 21:37:20 PDT

Created attachment 405221 [details]
proposed patch.

Comment 4 Yusuke Suzuki 2020-07-25 21:20:10 PDT

Comment on attachment 405221 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=405221&action=review

r=me

> Source/JavaScriptCore/runtime/JSObjectInlines.h:136
> +        if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put `UNLIKELY`.

> Source/JavaScriptCore/runtime/JSObjectInlines.h:179
> +            if (slot.isVMInquiry() && slot.isTaintedByOpaqueObject())

Let's put UNLIKELY

Comment 5 Mark Lam 2020-07-25 22:12:06 PDT

Thanks for the review.  I've applied the fixes.

Landed in r264895: <http://trac.webkit.org/r264895>.