Bug 214549

Summary: Some classes have final destructors but are non-final
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit2Assignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, clopez, darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2020-07-20 04:31:06 PDT
../Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h:68:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~WebSWServerConnection() final; ^
Attachments
Patch (2.49 KB, patch)
2020-07-20 04:37 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-07-20 04:33:09 PDT
Also WebMessagePortChannelProvider: ../Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:39:38: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~WebMessagePortChannelProvider() final; ^
Adrian Perez
Comment 2 2020-07-20 04:37:45 PDT
Created attachment 404710 [details] Patch
EWS
Comment 3 2020-07-20 06:41:57 PDT
Committed r264598: <https://trac.webkit.org/changeset/264598> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404710 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-20 06:42:13 PDT
<rdar://problem/65822676>
Note You need to log in before you can comment on or make changes to this bug.