Bug 214542

Summary: WebPageProxyIdentifier parameter of WebPageProxy::CreateNewPage() should not be Optional
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, useafterfree, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-07-19 20:04:48 PDT 
WebPageProxyIdentifier parameter of WebPageProxy::CreateNewPage() should not be Optional.

The method extracts the value of Optional<WebPageProxyIdentifier> unconditionally, so it's clear it doesn't need to be Optional<>.

<rdar://problem/65768644>
Comment 1 David Kilzer (:ddkilzer) 2020-07-19 20:07:59 PDT 
Created attachment 404695 [details]
Patch v1
Comment 2 EWS 2020-07-20 08:17:30 PDT 
Committed r264602: <https://trac.webkit.org/changeset/264602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404695 [details].