Bug 214532

Summary: AtomStringImpl should have more addWithStringTableProvider varieties, so Identifier can use them.
Product: WebKit Reporter: xc.o.c.1180 <xc.o.c.1180>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

xc.o.c.1180@gmail.com
Reported 2020-07-19 06:05:04 PDT
VM already has atomStringTable(), it is more efficient than looking it up. Currently, there is only one addWithStringTableProvider(StringTableProvider& stringTableProvider, StringImpl* string). There should be more, for example, WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const LChar*, unsigned length); WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const UChar*, unsigned length); So, Ref<StringImpl> Identifier::add(VM& vm, const T* s, int length) can use them.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-26 06:06:16 PDT
<rdar://problem/66125754>
Note You need to log in before you can comment on or make changes to this bug.