Bug 214530

Summary: cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="?
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, pnormand, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-07-19 05:05:10 PDT
Follow-up to bug #213971, we have one more syntax warning in cpp_generator.py [663/5091] Generating ../../DerivedSources/JavaScriptCore...s/JavaScriptCore/inspector/InspectorBackendCommands.js.in /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:134: SyntaxWarning: "is" with a literal. Did you mean "=="? if isinstance(_type, ObjectType) or _type.qualified_name() is 'object':
Attachments
Patch (1.68 KB, patch)
2020-07-19 05:05 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-07-19 05:05:59 PDT
Created attachment 404663 [details] Patch
EWS Watchlist
Comment 2 2020-07-19 05:06:40 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
EWS
Comment 3 2020-07-19 06:59:41 PDT
Committed r264576: <https://trac.webkit.org/changeset/264576> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404663 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-19 07:00:17 PDT
<rdar://problem/65787645>
Note You need to log in before you can comment on or make changes to this bug.