Bug 214517

Summary:	Regression (r264563): watchOS build broken
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	aakash_jain, ap, megan_gardner, webkit-bot-watchers-bugzilla
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=214195

Description Aakash Jain 2020-07-18 05:13:03 PDT

r264563 seems to have broken watchOS build. The latest patch wasn't run through EWS.

r264562 passed in https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/builds/791
r264563 failed in https://build.webkit.org/builders/Apple-watchOS-Simulator-6-Release-Build/builds/792

Comment 1 Aakash Jain 2020-07-18 05:13:37 PDT

In file included from /Volumes/Data/slave/watchos-simulator-13-release/build/WebKitBuild/Release-watchsimulator/DerivedSources/WebKit2/unified-sources/UnifiedSource46-mm.mm:4:
/Volumes/Data/slave/watchos-simulator-13-release/build/Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:89:18: error: no matching function for call to 'max'
    size.width = std::max(size.width, 250.0);
                 ^~~~~~~~

r264563 did modified WKDateTimeInputControl.mm and added the above line which is causing the issue.

Comment 2 Aakash Jain 2020-07-18 05:26:43 PDT


*** This bug has been marked as a duplicate of bug 214518 ***

Comment 3 Aakash Jain 2020-07-18 05:27:13 PDT

Reverted r264563 in Bug 214518.