Bug 214511

Summary:	[GTK][resultsdb] Revamp version and version_name when uploading results
Product:	WebKit	Reporter:	Lauro Moura <lmoura>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	bugs-noreply, dpino, jbedard
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=214087

Description Lauro Moura 2020-07-17 16:45:16 PDT

Currently, both GTK and WPE bots ignore the version field when uploading results, which ends up containing the kernel version, from the platform info object. Additionally, GTK uses the "version_info" field to distinguish the X11 bots from the Wayland ones (Maybe it should use flavor for this instead, as for these two ports it's always wk2?)

Ideally, version should be tied to something more meaningful, like the GTK version the GTK bots are using, as WebkitGTK started supporting GTK4 and will have test bots for it (bug213016) soon.

This would also help to avoid issues like bug214087, where a kernel update started showing different result series for the same bots.

Note: This should not affect the build bots directly, only the results displayed at the results site.

Comment 1 Jonathan Bedard 2020-07-20 07:23:40 PDT

platforminfo.py is probably the right place to do this, the same way we set a custom os_version for Mac.

If we don't want to do it here, we should override configuration_for_upload in the GtkPort.